tillrohrmann commented on a change in pull request #10762: [FLINK-15115][kafka]
Drop Kafka 0.8/0.9
URL: https://github.com/apache/flink/pull/10762#discussion_r365331071
##########
File path:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThreadTest.java
##########
@@ -1047,17 +1047,41 @@ public OffsetAndMetadata committed(TopicPartition
topicPartition) {
}
@Override
- public void pause(TopicPartition... topicPartitions) {
+ public Set<TopicPartition> paused() {
+ return null;
+ }
+
+ @Override
+ public void pause(Collection<TopicPartition> collection) {
+ }
+
+ @Override
+ public void resume(Collection<TopicPartition> collection) {
}
@Override
- public void resume(TopicPartition... topicPartitions) {
+ public Map<TopicPartition, OffsetAndTimestamp>
offsetsForTimes(Map<TopicPartition, Long> map) {
+ return null;
Review comment:
I would suggest to either fail or to return an empty map but not `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
