tillrohrmann commented on a change in pull request #10665: [FLINK-15354] Start 
and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365355603
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
 ##########
 @@ -30,7 +30,7 @@ function cleanup {
     kubectl delete job flink-job-cluster
     kubectl delete service flink-job-cluster
     kubectl delete deployment flink-task-manager
-    rm -rf ${OUTPUT_VOLUME}
 
 Review comment:
   Does `stop_kubernetes` delete the `${OUTPUT_VOLUME}`? Or why is this no 
longer needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to