[ 
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011011#comment-15011011
 ] 

ASF GitHub Bot commented on FLINK-2017:
---------------------------------------

Github user mliesenberg commented on the pull request:

    https://github.com/apache/flink/pull/1097#issuecomment-157719075
  
    optional in the sense of, if the list is passed, then the missing arguments 
are added to the help text in an extra paragraph at the end. 
    realized probably via method overloading. 


> Add predefined required parameters to ParameterTool
> ---------------------------------------------------
>
>                 Key: FLINK-2017
>                 URL: https://issues.apache.org/jira/browse/FLINK-2017
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>              Labels: starter
>
> In FLINK-1525 we've added the {{ParameterTool}}.
> During the PR review, there was a request for required parameters.
> This issue is about implementing a facility to define required parameters. 
> The tool should also be able to print a help menu with a list of all 
> parameters.
> This test case shows my initial ideas how to design the API
> {code}
>       @Test
>       public void requiredParameters() {
>               RequiredParameters required = new RequiredParameters();
>               Option input = required.add("input").alt("i").help("Path to 
> input file or directory"); // parameter with long and short variant
>               required.add("output"); // parameter only with long variant
>               Option parallelism = 
> required.add("parallelism").alt("p").type(Integer.class); // parameter with 
> type
>               Option spOption = 
> required.add("sourceParallelism").alt("sp").defaultValue(12).help("Number 
> specifying the number of parallel data source instances"); // parameter with 
> default value, specifying the type.
>               Option executionType = 
> required.add("executionType").alt("et").defaultValue("pipelined").choices("pipelined",
>  "batch");
>               ParameterUtil parameter = ParameterUtil.fromArgs(new 
> String[]{"-i", "someinput", "--output", "someout", "-p", "15"});
>               required.check(parameter);
>               required.printHelp();
>               required.checkAndPopulate(parameter);
>               String inputString = input.get();
>               int par = parallelism.getInteger();
>               String output = parameter.get("output");
>               int sourcePar = parameter.getInteger(spOption.getName());
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to