kl0u commented on a change in pull request #10833: [FLINK-15535][documentation] 
Add usage of ProcessFunctionTestHarnesses for testing documentation
URL: https://github.com/apache/flink/pull/10833#discussion_r366268509
 
 

 ##########
 File path: docs/dev/stream/testing.md
 ##########
 @@ -332,6 +332,87 @@ Many more examples for the usage of these test harnesses 
can be found in the Fli
 
 <span class="label label-info">Note</span> Be aware that 
`AbstractStreamOperatorTestHarness` and its derived classes are currently not 
part of the public API and can be subject to change.
 
+### Unit Testing ProcessFunction
+
+The `ProcessFunction` is a widely used low-level and powerful stream 
processing operation, giving access to the basic building blocks of all 
(acyclic) streaming applications.
+Flink provides a test harness named `ProcessFunctionTestHarnesses` that can be 
used to test your `ProcessFunction`. Considering this example:
 
 Review comment:
   I would change this phrase to something like: "Given its importance, in 
addition to the previous test harnesses that can used directly to test a 
`ProcessFunction`, Flink provides a test harness factory named 
`ProcessFunctionTestHarnesses` that allows for easier test harness 
instantiation. Considering this example:"
   
   Or something along these lines.
   
   In addition, I think it should be mentioned explicitly that in order to use 
these methods, the user should include the previous changes in his/her `pom` 
file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to