zhuzhurk commented on a change in pull request #10832:
[FLINK-14163][runtime]Enforce synchronous registration of
Execution#producedPartitions
URL: https://github.com/apache/flink/pull/10832#discussion_r366734687
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java
##########
@@ -540,6 +553,46 @@ public void testSlotReleaseAtomicallyReleasesExecution()
throws Exception {
});
}
+ /**
+ * Tests that producedPartitions are registered synchronously under an
asynchronous interface.
+ */
+ @Test(expected = IllegalStateException.class)
+ public void testSynchronousRegisterProducedPartitions() throws
Exception {
+ final ScheduledExecutorService executor = new
DirectScheduledExecutorService();
+ final ShuffleMaster<ShuffleDescriptor> shuffleMaster = new
TestingShuffleMaster();
+
+ final ExecutionJobVertex sourceJobVertex =
getExecutionVertex(new JobVertexID(), executor, EAGER, shuffleMaster);
Review comment:
I think we should create an ExecutionGraph and get the vertices from it
rather than using this `getExecutionVertex(...)` to create vertices. Otherwise
these 2 vertices are actually from 2 different ExecutionGraphs.
In this way you do not need to create edges manually. You can leverage
TestingExecutionGraphBuilder to build an ExecutionGraph and set the wanted
shuffle master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
