bowenli86 commented on a change in pull request #10879: [FLINK-15595][table]
Remove CoreMudule in ModuleManager
URL: https://github.com/apache/flink/pull/10879#discussion_r368076119
##########
File path: docs/dev/table/modules.md
##########
@@ -101,8 +93,6 @@ The following types are supported out of the box.
{% highlight yaml %}
modules:
- - name: core
- type: core
Review comment:
if in 1.11 we add back core module, this would be a problem because sql
client requires users listing all modules in yaml file. So if users just
upgrade to 1.11 without putting core module here, sql client would assume users
are explicitly not loading core.
I'm not sure what a better solution can be though, thus I'm neutral to this
change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
