[ https://issues.apache.org/jira/browse/FLINK-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019194#comment-17019194 ]
Congxian Qiu(klion26) commented on FLINK-15637: ----------------------------------------------- Ran the benchmark of {{RocksDBStateBackend}}, there will be some regression after applying this change. for no incremental mode, there is 4.6% regression, and 2.9% regression for incremental mode. * Result before applying the change {code:java} Benchmark (stateBackend) Mode Cnt Score Error Units RocksStateBackendBenchmark.stateBackends ROCKS thrpt 30 203.893 ± 1.580 ops/ms RocksStateBackendBenchmark.stateBackends ROCKS_INC thrpt 30 201.896 ± 5.179 ops/ms {code} * Result after applying the change {code:java} Benchmark (stateBackend) Mode Cnt Score Error Units RocksStateBackendBenchmark.stateBackends ROCKS thrpt 30 194.382 ± 2.256 ops/ms RocksStateBackendBenchmark.stateBackends ROCKS_INC thrpt 30 195.912 ± 2.151 ops/ms {code} Steps for generating the result # checkout the commit before applying the change and install # run the benchmark to get the result # checkout the commit after applying the change and install # run the benchmark to get the result. > For RocksDBStateBackend, make RocksDB the default store for timers > ------------------------------------------------------------------ > > Key: FLINK-15637 > URL: https://issues.apache.org/jira/browse/FLINK-15637 > Project: Flink > Issue Type: Improvement > Components: Runtime / State Backends > Reporter: Stephan Ewen > Priority: Blocker > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Set the {{state.backend.rocksdb.timer-service.factory}} to {{ROCKSDB}} by > default. Also ensure that the programmatic default value becomes the same. > We need to update the performance tuning guide to mention this. > > We need to update the release notes to mention this. > -- This message was sent by Atlassian Jira (v8.3.4#803005)