tillrohrmann commented on a change in pull request #10682:
[FLINK-15247][Runtime] Wait for all slots to be free before task executor
services shutdown upon stopping
URL: https://github.com/apache/flink/pull/10682#discussion_r369008460
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##########
@@ -383,9 +123,7 @@ public boolean markSlotInactive(AllocationID allocationId,
Time slotTimeout) thr
* @throws SlotNotFoundException if there is not task slot for the
given allocation id
* @return Index of the freed slot if the slot could be freed;
otherwise -1
*/
- public int freeSlot(AllocationID allocationId) throws
SlotNotFoundException {
- return freeSlot(allocationId, new Exception("The task slot of
this task is being freed."));
- }
+ int freeSlot(AllocationID allocationId) throws SlotNotFoundException;
Review comment:
Can't have this method have a default implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
