tillrohrmann commented on a change in pull request #10921: [FLINK-15692][state 
backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369585450
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java
 ##########
 @@ -71,12 +74,26 @@
 
        protected abstract B getStateBackend() throws Exception;
 
+       protected abstract long getManagedMemorySize();
+
        @Rule
        public final TemporaryFolder tempFolder = new TemporaryFolder();
 
+       @Before
+       public void before() {
+               env = 
MockEnvironment.builder().setMemorySize(getManagedMemorySize()).build();
 
 Review comment:
   I would suggest to rename `MockEnvironmentBuilder.setMemorySize` into 
`setManagedMemorySize`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to