tillrohrmann commented on a change in pull request #10971:
[FLINK-15791][kubernetes] Use explicit I/O Executor for asynchronous operations
in Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10971#discussion_r373477951
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -81,6 +85,8 @@
private final List<Decorator<Deployment, KubernetesDeployment>>
flinkMasterDeploymentDecorators = new ArrayList<>();
private final List<Decorator<Pod, KubernetesPod>>
taskManagerPodDecorators = new ArrayList<>();
+ private final ExecutorService executorService =
Executors.newFixedThreadPool(4, new
ExecutorThreadFactory("Flink-KubeClient-IO"));
Review comment:
The lifecycle management of `executorService` is missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
