[ 
https://issues.apache.org/jira/browse/FLINK-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028463#comment-17028463
 ] 

Roman Leventov commented on FLINK-15838:
----------------------------------------

A typical outcome is a test not really testing production code, though falsely 
reporting "coverage". Such tests will be green regardless of whether the 
production logic is correct or not.

> Dangling CountDownLatch.await(timeout)
> --------------------------------------
>
>                 Key: FLINK-15838
>                 URL: https://issues.apache.org/jira/browse/FLINK-15838
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Roman Leventov
>            Priority: Major
>
> There are 16 occurrences in the codebase (all in test code) when the result 
> of CountDownLatch.await(timeout, TimeUnit) is not checked. It's like not 
> checking the result of File.delete(). The common fix is to wrap CDL.await() 
> call into assertTrue().
> All 16 places could be found using the following structural search in 
> IntelliJ:
> $x$.await($y$, $z$);
> With "CountDownLatch" type constraint on the $x$ variable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to