[ 
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022586#comment-15022586
 ] 

ASF GitHub Bot commented on FLINK-2111:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r45635645
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
 ---
    @@ -188,9 +189,12 @@ public WebRuntimeMonitor(
     
                        // Cancel a job via GET (for proper integration with 
YARN this has to be performed via GET)
                        .GET("/jobs/:jobid/yarn-cancel", handler(new 
JobCancellationHandler()))
    -                   // DELETE is the preferred way of cancelling a job 
(Rest-conform)
    +                   // DELETE is the preferred way of canceling a job 
(Rest-conform)
                        .DELETE("/jobs/:jobid", handler(new 
JobCancellationHandler()))
     
    +                   // stop a job
    +                   .DELETE("/jobs/:jobid/stop", handler(new 
JobStoppingHandler()))
    +
    --- End diff --
    
    Why is there actually `GET` and `DELETE` for `cancel`? Why not just `GET`?


> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
>                 Key: FLINK-2111
>                 URL: https://issues.apache.org/jira/browse/FLINK-2111
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime, JobManager, Local Runtime, 
> Streaming, TaskManager, Webfrontend
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is 
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks 
> such that the sources can stop emitting data and shutdown cleanly, resulting 
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for 
> https://issues.apache.org/jira/browse/FLINK-1929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to