[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

[sachingoel0101]

Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r45635941
  
    --- Diff: flink-runtime-web/web-dashboard/web/partials/jobs/job.html ---
    @@ -32,7 +32,7 @@
           - 
           {{ job['end-time'] | amDateFormat:'YYYY-MM-DD, H:mm:ss' 
}}</span></div>
       <div ng-if="job.duration &gt; -1" title="{{job.duration | 
humanizeDuration:false}}" class="navbar-info last first">{{job.duration | 
humanizeDuration:true}}</div>
    -  <div ng-if="job.state=='RUNNING' || job.state=='CREATED' || 
job.state=='RESTARTING'" class="navbar-info last first"><span 
ng-click="cancelJob($event)" class="navbar-info-button btn 
btn-default">Cancel</span></div>
    +  <div ng-if="job.type=='STREAMING' && (job.state=='RUNNING' || 
job.state=='CREATED' || job.state=='RESTARTING')" class="navbar-info last 
first"><span ng-click="cancelJob($event)" class="navbar-info-button btn 
btn-default">Cancel</span></div>
    --- End diff --
    
    This is weird. The stop button code isn't actually here. Are you sure this 
file is up-to-date? Can you run gulp again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---