lirui-apache commented on issue #10730: [FLINK-14802][orc][hive] Multi vectorized read version support for hive orc read URL: https://github.com/apache/flink/pull/10730#issuecomment-583265783 @JingsongLi Thanks for working on this. PR LGTM overall. One suggestion is to avoid giving classes in `flink-orc` and `flink-orc-nohive` the same name. IMO we already have too many classes sharing the same name in Flink, which makes the code awfully unreadable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
