twalthr commented on a change in pull request #11036: [hotfix][example] Add
StreamWindowSQLExample.jar to dist
URL: https://github.com/apache/flink/pull/11036#discussion_r376283746
##########
File path:
flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/StreamWindowSQLExample.java
##########
@@ -60,7 +62,6 @@ public static void main(String[] args) throws Exception {
tempFile.deleteOnExit();
Review comment:
nit: could we move those 4 helper lines into a method like "String path =
createTempFile(orders)". They are actually not important for understanding
Flink and should be moved down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
