wuchong commented on a change in pull request #11047: [FLINK-15912][table] Add
Context to TableSourceFactory and TableSinkFactory
URL: https://github.com/apache/flink/pull/11047#discussion_r377452557
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/factories/TableFactoryUtil.java
##########
@@ -103,4 +103,15 @@
return Optional.empty();
}
+ /**
Review comment:
We should make sure `TableSinkFactory#createTableSink(context)` is the only
entry to be invoked by the planner. However, the above
`createTableSinkForCatalogTable` method still calling the old `createTableSink`
method in old planner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
