[ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024316#comment-15024316 ]
ASF GitHub Bot commented on FLINK-2837: --------------------------------------- Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1398#discussion_r45724616 --- Diff: docs/apis/storm_compatibility.md --- @@ -57,20 +57,22 @@ See *WordCount Storm* within `flink-storm-examples/pom.xml` for an example how t Flink provides a Storm compatible API (`org.apache.flink.storm.api`) that offers replacements for the following classes: -- `TopologyBuilder` replaced by `FlinkTopologyBuilder` - `StormSubmitter` replaced by `FlinkSubmitter` - `NimbusClient` and `Client` replaced by `FlinkClient` - `LocalCluster` replaced by `FlinkLocalCluster` -In order to submit a Storm topology to Flink, it is sufficient to replace the used Storm classes with their Flink replacements in the Storm *client code that assembles* the topology. -The actual runtime code, ie, Spouts and Bolts, can be uses *unmodified*. -If a topology is executed in a remote cluster, parameters `nimbus.host` and `nimbus.thrift.port` are used as `jobmanger.rpc.address` and `jobmanger.rpc.port`, respectively. -If a parameter is not specified, the value is taken from `flink-conf.yaml`. +In order to submit a Storm topology to Flink, it is sufficient to replace the +used Storm classes with their Flink replacements in the Storm *client code that +assembles* the topology. The actual runtime code, ie, Spouts and Bolts, can be +used *unmodified*. If a topology is executed in a remote cluster, parameters +`nimbus.host` and `nimbus.thrift.port` are used as `jobmanger.rpc.address` and +`jobmanger.rpc.port`, respectively. If a parameter is not specified, the value +is taken from `flink-conf.yaml`. --- End diff -- I like the single-line format because it make reviewing easier. If you have fixed line length, changing a small thing can lead for reformatting of a whole paragraph due to new line breaks etc. This make spotting the actual change quite hard. (I would appreciate it, if we could keep the current formatting -- but if is not "an issue" in the strong sense). > FlinkTopologyBuilder cannot handle multiple input streams > --------------------------------------------------------- > > Key: FLINK-2837 > URL: https://issues.apache.org/jira/browse/FLINK-2837 > Project: Flink > Issue Type: Bug > Components: Storm Compatibility > Reporter: Matthias J. Sax > Assignee: Maximilian Michels > > FlinkTopologyBuilder cannot handle multiple input streams correctly. Instead > of union the incoming streams, it replicates the consuming bolt and each > (logical) instance processes one of the input streams. > For example: > {noformat} > final FlinkTopologyBuilder builder = new FlinkTopologyBuilder(); > builder.setSpout(spoutId1, new FiniteRandomSpout(0, 10)); > builder.setSpout(spoutId2, new FiniteRandomSpout(1, 8)); > builder.setSpout(spoutId3, new FiniteRandomSpout(2, 13)); > builder.setBolt(boltId, new MergerBolt()) > .shuffleGrouping(spoutId1) > .shuffleGrouping(spoutId2) > .shuffleGrouping(spoutId3); > builder.setBolt("sink", new BoltPrintSink(new SimpleOutputFormatter())) > .shuffleGrouping(boltId); > {noformat} > will only print the data from a single source instead of all sources. -- This message was sent by Atlassian JIRA (v6.3.4#6332)