rmetzger commented on a change in pull request #10976: [FLINK-13978][build
system] Add experimental support for building on Azure Pipelines
URL: https://github.com/apache/flink/pull/10976#discussion_r378389823
##########
File path:
flink-end-to-end-tests/test-scripts/test_mesos_multiple_submissions.sh
##########
@@ -29,7 +29,7 @@
TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
function submit_job {
local output_path=$1
- docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1
${TEST_PROGRAM_JAR} --durationInSecond ${DURATION} --outputPath ${output_path}"
\
+ docker exec mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1
${TEST_PROGRAM_JAR} --durationInSecond ${DURATION} --outputPath ${output_path}"
\
Review comment:
`docker exec -it` is basically for using Docker interactively (e.g. you want
to run `bash` inside a container and talk to bash).
`-i Keep STDIN open even if not attached`
`-t Allocate a pseudo-TTY`
It's just not necessary to pass `-it` (and IIRC it even logs a warning)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
