hequn8128 commented on a change in pull request #11051: [FLINK-15961][table-planner][table-planner-blink] Introduce Python Physical Correlate RelNodes which are containers for Python TableFunction URL: https://github.com/apache/flink/pull/11051#discussion_r379240935
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchExecCorrelate.scala ########## @@ -18,30 +18,19 @@ package org.apache.flink.table.planner.plan.nodes.physical.batch import org.apache.flink.api.dag.Transformation -import org.apache.flink.runtime.operators.DamBehavior import org.apache.flink.table.dataformat.BaseRow import org.apache.flink.table.planner.codegen.{CodeGeneratorContext, CorrelateCodeGenerator} import org.apache.flink.table.planner.delegation.BatchPlanner -import org.apache.flink.table.planner.functions.utils.TableSqlFunction -import org.apache.flink.table.planner.plan.`trait`.{FlinkRelDistribution, FlinkRelDistributionTraitDef, TraitUtil} -import org.apache.flink.table.planner.plan.nodes.exec.{BatchExecNode, ExecNode} import org.apache.flink.table.planner.plan.nodes.logical.FlinkLogicalTableFunctionScan -import org.apache.flink.table.planner.plan.utils.RelExplainUtil -import org.apache.calcite.plan.{RelOptCluster, RelOptRule, RelTraitSet} +import org.apache.calcite.plan.{RelOptCluster, RelTraitSet} import org.apache.calcite.rel.`type`.RelDataType import org.apache.calcite.rel.core.{Correlate, JoinRelType} -import org.apache.calcite.rel.{RelCollationTraitDef, RelDistribution, RelFieldCollation, RelNode, RelWriter, SingleRel} -import org.apache.calcite.rex.{RexCall, RexInputRef, RexNode, RexProgram} -import org.apache.calcite.sql.SqlKind -import org.apache.calcite.util.mapping.{Mapping, MappingType, Mappings} - -import java.util - -import scala.collection.JavaConversions._ +import org.apache.calcite.rel.RelNode +import org.apache.calcite.rex.{RexNode, RexProgram} /** - * Batch physical RelNode for [[Correlate]] (user defined table function). + * Batch physical RelNode for [[Correlate]] (Java user defined table function). Review comment: Java => Java/Scala ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services