hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml]
Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379951593
##########
File path: flink-dist/src/main/assemblies/opt.xml
##########
@@ -168,6 +168,14 @@
<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
<fileMode>0644</fileMode>
</file>
+
+ <!-- ML (API & LIB) -->
+ <file>
Review comment:
For the table module, it makes no sense to let any sub-modules to bundle
cep, so a uber module is used to create the bundled jar. but for ml module, it
makes sense to let flink-ml-lib to bundle the flink-ml-api module, so that we
can simply put the flink-ml-lib jar into the opt.
Anyway, I have created an uber module for the flink-ml in the latest pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
