hequn8128 commented on a change in pull request #11051: [FLINK-15961][table-planner][table-planner-blink] Introduce Python Physical Correlate RelNodes which are containers for Python TableFunction URL: https://github.com/apache/flink/pull/11051#discussion_r379227379
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamCorrelateBase.scala ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.table.plan.nodes.datastream + +import org.apache.calcite.plan.{RelOptCluster, RelTraitSet} +import org.apache.calcite.rel.{RelNode, RelWriter, SingleRel} +import org.apache.calcite.rel.core.JoinRelType +import org.apache.calcite.rex.{RexCall, RexNode} +import org.apache.flink.table.functions.utils.TableSqlFunction +import org.apache.flink.table.plan.nodes.CommonCorrelate +import org.apache.flink.table.plan.nodes.logical.FlinkLogicalTableFunctionScan +import org.apache.flink.table.plan.schema.RowSchema + +/** + * Base RelNode for data stream correlate. + */ +abstract class DataStreamCorrelateBase( Review comment: Hi @twalthr It seems we can't use the implemented methods of a Scala trait from Java([see details](https://alvinalexander.com/scala/how-to-wrap-scala-traits-used-accessed-java-classes-methods)) which prevents us from turning this class to a Java one. For this class, it needs to extend two traits, i.e., CommonCorrelate and DataStreamRel. Maybe we can keep this class as a Scala one for now. What do you think? I have checked that the classes of Rule has been implemented in Java in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
