zhijiangW commented on issue #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#issuecomment-586823140 Let's uniform the new class naming and refactor the structure a bit firstly. - `ZeroCopyNettyMessageDecoder` -> `NettyMessageClientDecoder`: `ZeroCopy` is not an easy understood term or glossary by other persons. From the semantic of itself, actually we have not achieved the goal of zero copy yet. - The previous `NettyMessageDecoder` refactors to respective `NettyMessageServerDecoder` - `NettyMessageParser` -> `NettyMessageDeocderDelegate`: The motivation is to unify the `Parser` and `Decoder` terms. Further we can define it as abstract `NettyMessageDeocderDelegate` to extend `ChannelInboundHandlerAdapter`, then it can make use of existing `channelActive` and `channelInactive` methods to avoid re-define them now. - `BufferResponseParser` -> `BufferResponseDecoderDelegate` - `DefaultMessageParser` -> `NonBufferResponseDecoderDelegate`? The `Default` term is misleading and we should give a more precise semantic. - `ByteBufCumulator` -> `LengthBasedHeaderDecoder`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
