wuchong commented on a change in pull request #11047: [FLINK-15912][table] Add
Context to TableSourceFactory and TableSinkFactory
URL: https://github.com/apache/flink/pull/11047#discussion_r380000855
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/TableSinkFactory.java
##########
@@ -40,7 +42,9 @@
* @param properties normalized properties describing a table sink.
* @return the configured table sink.
*/
- TableSink<T> createTableSink(Map<String, String> properties);
+ default TableSink<T> createTableSink(Map<String, String> properties) {
Review comment:
I think we can also deprecate this method now, as what we do for
`TableSink#getOutputType` when `getConsumedDataType` is introduced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
