Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734177
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class FiniteFileSpout extends FileSpout implements FiniteSpout {
private static final long serialVersionUID = -1472978008607215864L;
- private String line;
- private boolean newLineRead;
-
public FiniteFileSpout() {}
public FiniteFileSpout(String path) {
super(path);
}
- @SuppressWarnings("rawtypes")
- @Override
- public void open(final Map conf, final TopologyContext context, final
SpoutOutputCollector collector) {
- super.open(conf, context, collector);
- newLineRead = false;
- }
-
- @Override
- public void nextTuple() {
- this.collector.emit(new Values(line));
- newLineRead = false;
- }
-
/**
* Can be called before nextTuple() any times including 0.
*/
@Override
public boolean reachedEnd() {
- try {
- readLine();
- } catch (IOException e) {
- throw new RuntimeException("Exception occured while
reading file " + path);
- }
- return line == null;
+ return finished;
}
--- End diff --
Following your argument, we should also remove the `FiniteSpout`
functionality, because it is not included in Storm as well. I'll revert this
but I don't understand your argument.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
