Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45743505
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void testCreateTopologyContext() {
builder.setBolt("bolt2", (IRichBolt) operators.get("bolt2"),
dops.get("bolt2")).allGrouping("spout2");
builder.setBolt("sink", (IRichBolt) operators.get("sink"),
dops.get("sink"))
.shuffleGrouping("bolt1",
TestDummyBolt.groupingStreamId)
- .shuffleGrouping("bolt1",
TestDummyBolt.shuffleStreamId)
- .shuffleGrouping("bolt2",
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2",
TestDummyBolt.shuffleStreamId);
--- End diff --
Well. Get it right from the beginning. I think it was all but right until
now :) And in this regard, its much more defined now. At least you get an error
if you have more than two inputs.
I agree that we should fix this. But it's going to be a bit tricky because
we have to hack around Flink's limitation. I would rather not do this in this
pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
