zhijiangW commented on issue #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#issuecomment-591812975 Thanks for the updates and patience @gaoyunhaii . The core codes are almost good now except for one concern of buffer leak left inline comment. I only roughly reviewed the tests part and found two main problems, one is for deduplication and anther is for avoid mocking way in new tests. After you address these issues, then i would review the detail logics in tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
