[
https://issues.apache.org/jira/browse/FLINK-15314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047778#comment-17047778
]
Gary Yao commented on FLINK-15314:
----------------------------------
[~lining] Did you run into a concrete problem that made you want to refactor
this? Should I already assign you to the ticket, or do you want to work on it
later?
> To refactor duplicated code in
> TaskManagerDetailsHandler#createTaskManagerMetricsInfo
> -------------------------------------------------------------------------------------
>
> Key: FLINK-15314
> URL: https://issues.apache.org/jira/browse/FLINK-15314
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics, Runtime / REST
> Reporter: lining
> Priority: Major
>
> As
> [code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerDetailsHandler.java#L119-L142]
> show, use hard codes to define metrics' name. Could we unify where to
> register and get metrics?
> * propose
> ** move metrics'name define in MetricUtils to MetricNames
> ** the all get the name form MetricNames
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
