docete opened a new pull request #11276: [FLINK-16029][table-planner-blink] 
Remove register source and sink in test cases of blink planner
URL: https://github.com/apache/flink/pull/11276
 
 
   ## What is the purpose of the change
   Many test cases of planner use TableEnvironement.registerTableSource() and 
registerTableSink() which should be avoid. We want to refactor these cases via 
TableEnvironment.connect(). This PR 
   remove most of these calls except in two situations
   1)table sources implements DefinedRowtimeAttributes or 
DefinedProctimeAttribute, which will be handled by 
https://issues.apache.org/jira/browse/FLINK-16160
   2) TableTestBase#addTableSource which will be handled by 
https://issues.apache.org/jira/browse/FLINK-16117
   
   ## Brief change log
   
   - b53f6b1 Port CustomConnectorDescriptor to flink-table-common module
   - f70d4bc-7030331 Replace TableEnvironment.registerTableSource/Sink() by 
TableEnvironment.connect()
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / 
**JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to