zhijiangW commented on a change in pull request #7368: [FLINK-10742][network]
Let Netty use Flink's buffers directly in credit-based mode
URL: https://github.com/apache/flink/pull/7368#discussion_r386241044
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandlerTest.java
##########
@@ -446,7 +546,11 @@ private static BufferResponse createBufferResponse(
// Deserialize the bytes again. We have to go this way, because
we only partly deserialize
// the header of the response and wait for a buffer from the
buffer pool to copy the payload
// data into.
Review comment:
`wait for a buffer from the buffer pool to copy the payload data into.`
should be properly adjusted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
