lirui-apache commented on issue #11275: [FLINK-16359][table-runtime] Introduce WritableVectors for abstract writing URL: https://github.com/apache/flink/pull/11275#issuecomment-593314494 Thanks @JingsongLi for the PR. I left some minor comments. Also noted we're doing some mem copy in methods like `HeapDoubleVector::setDoublesFromBinary `, and wonder whether we should add some safety check to make sure the source/dest have sufficient space, so as to avoid potential segment faults?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
