nielsbasjes commented on a change in pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version URL: https://github.com/apache/flink/pull/11245#discussion_r386336444
########## File path: docs/ops/deployment/kubernetes.md ########## @@ -112,7 +112,7 @@ An early version of a [Flink Helm chart](https://github.com/docker-flink/example ### Session cluster resource definitions -The Deployment definitions use the pre-built image `flink:latest` which can be found [on Docker Hub](https://hub.docker.com/r/_/flink/). +The Deployment definitions use the pre-built image `flink:{{ site.version }}-scala_2.11` (or `flink:{{ site.version }}-scala_2.12`) which can be found [on Docker Hub](https://hub.docker.com/r/_/flink/). Review comment: - Strange. I see here that the site.version for 1.9.2 was actually set to 1.9.2 : https://github.com/apache/flink/blob/release-1.9.2/docs/_config.yml#L30 . I do agree that for example https://ci.apache.org/projects/flink/flink-docs-release-1.9/dev/connectors/pubsub.html still shows 1.9.0. To me this seems more like the site needs to be regenerated than this variable having the incorrect value. - Perhaps on releasing a 'SNAPSHOT' version of the software a 'SNAPSHOT' version docker image with the same software should be released too? On the other hand ... it is 'just documentation'. I do see that apparently the 2.12 is 'preferred' so I'm swapping them in the documentation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
