zentol commented on a change in pull request #11195: [FLINK-16222][runtime] Use
plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r386478652
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java
##########
@@ -120,55 +124,37 @@ public static ReporterSetup forReporter(String
reporterName, MetricConfig metric
}
private static ReporterSetup createReporterSetup(String reporterName,
MetricConfig metricConfig, MetricReporter reporter) {
- LOG.info("Configuring {} with {}.", reporterName, metricConfig);
+ LOG.debug("Configuring {} with {}.", reporterName,
metricConfig);
reporter.open(metricConfig);
return new ReporterSetup(reporterName, metricConfig, reporter);
}
- public static List<ReporterSetup> fromConfiguration(final Configuration
configuration) {
+ public static List<ReporterSetup> fromConfiguration(final Configuration
configuration, final PluginManager pluginManager) {
+ LOG.debug("Initializing Reporters from Configuration: {}",
configuration);
String includedReportersString =
configuration.getString(MetricOptions.REPORTERS_LIST, "");
- Set<String> includedReporters =
reporterListPattern.splitAsStream(includedReportersString)
Review comment:
reviews are a lot easier if we either a) refrain from non-critical
refactorings b) move such refactorings into a separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
