xintongsong commented on a change in pull request #11284: [FLINK-15911][runtime] Make Flink work with NAT. URL: https://github.com/apache/flink/pull/11284#discussion_r386818991
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceBuilder.java ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rpc.akka; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.akka.AkkaUtils; +import org.apache.flink.runtime.clusterframework.BootstrapTools; +import org.apache.flink.util.NetUtils; +import org.apache.flink.util.Preconditions; + +import akka.actor.ActorSystem; +import com.typesafe.config.Config; +import org.slf4j.Logger; + +import javax.annotation.Nullable; + +import java.net.InetAddress; + +/** + * Builder for {@link AkkaRpcService}. + */ +public class AkkaRpcServiceBuilder { Review comment: I think whether we want to make a constructor private, depends on whether allowing it to be accessed from outside may cause problem. E.g., the none argument constructor of `ResourceProfile` must be private because the only case we need it is for constructing the singleton instance `UNKNOWN`. If we allow to create another instance of `ResourceProfile` with this none argument constructor, the created instance may not work properly. In this case, I don't see such problem in allowing direct access to the constructors. That makes hiding the constructors a nice but not must to have approach, by which we suggest people to choose the more convenient builders. On the other hand, it is not about how many efforts needed that we do not use builders in the test cases. Currently, the builder does two things: create a `ActorSystem`, and use it to create a `AkkaRpcService`. However, in many test cases, we need to use a custom testing actor system, which is different from the one we created for production. That's way we cannot easily use builders in the tests. We could also make the builder to support custom actor system. But that complicates the builder logics (what should we do if both custom actor system and the fields for creating the production actor system are provided), and I think it doesn't make sense to do for pure testing purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
