zentol commented on a change in pull request #11305: [FLINK-16410][e2e][build] 
Add explicit flink-runtime dependency
URL: https://github.com/apache/flink/pull/11305#discussion_r387677812
 
 

 ##########
 File path: flink-end-to-end-tests/flink-end-to-end-tests-common/pom.xml
 ##########
 @@ -55,6 +55,12 @@ under the License.
                        <artifactId>flink-test-utils-junit</artifactId>
                        <scope>compile</scope>
                </dependency>
+               <dependency>
+                       <groupId>org.apache.flink</groupId>
+                       
<artifactId>flink-runtime_${scala.binary.version}</artifactId>
+                       <version>${project.version}</version>
+                       <scope>compile</scope>
+               </dependency>
 
 Review comment:
   As for why this was discovered now, when the prometheus/metrics e2e tests 
were working against the `FlinkDistribution` they weren't reliant on any REST 
calls, and didn't run into the issue. After the migration to the 
`FlinkResource` they implicitly gained a dependency on REST calls, hence the 
problem.
   Existing users of the `FlinkResource`, (i.e., kafka) have a separate runtime 
dependencies pulled in transitively via some other dependency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to