TisonKun commented on a change in pull request #11233: [FLINK-16194][k8s] Refactor the Kubernetes decorator design URL: https://github.com/apache/flink/pull/11233#discussion_r387862667
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubernetesJobManagerSpecification.java ########## @@ -16,19 +16,32 @@ * limitations under the License. */ -package org.apache.flink.kubernetes.kubeclient.resources; - -import org.apache.flink.configuration.Configuration; +package org.apache.flink.kubernetes.kubeclient; +import io.fabric8.kubernetes.api.model.HasMetadata; import io.fabric8.kubernetes.api.model.apps.Deployment; -import io.fabric8.kubernetes.api.model.apps.DeploymentBuilder; + +import java.util.List; /** - * Represent KubernetesDeployment resource in kubernetes. + * Composition of the created Kubernetes components that represents a Flink application. Review comment: You can edit the commit introduce this instead of adding fixup. I think we agree on most of codes now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
