[
https://issues.apache.org/jira/browse/FLINK-15791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052057#comment-17052057
]
Yang Wang edited comment on FLINK-15791 at 3/5/20, 11:58 AM:
-------------------------------------------------------------
[~trohrmann], since the FLINK-16194(Refactor the Kubernetes decorator design)
has remove the action watcher by design. I will close this PR and moving the
explicit I/O Executor implementation to FLINK-15790(Make FlinkKubeClient and
its implementations asynchronous).
was (Author: fly_in_gis):
[~trohrmann], since the #FLINK-16194(Refactor the Kubernetes decorator design)
has remove the action watcher by design. I will close this PR and moving the
explicit I/O Executor implementation to #FLINK-15790(Make FlinkKubeClient and
its implementations asynchronous).
> Don't use ForkJoinPool#commonPool() for executing asynchronous operations in
> Fabric8FlinkKubeClient
> ---------------------------------------------------------------------------------------------------
>
> Key: FLINK-15791
> URL: https://issues.apache.org/jira/browse/FLINK-15791
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Till Rohrmann
> Assignee: Yang Wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.1, 1.11.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should not use the {{ForkJoinPool#commonPool()}} in order to run
> asynchronous operations in the {{Fabric8FlinkKubeClient}} as it is done
> [here|https://github.com/apache/flink/blob/master/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java#L315].
> Since we don't know which other component is using this pool, it can be
> quite dangerous to use it as there might be congestion.
> Instead, I propose to provide an explicit I/O {{Executor}} which is used for
> running asynchronous operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
