xintongsong commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r389454700
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -804,22 +808,31 @@ private boolean
isFulfillableByRegisteredSlots(ResourceProfile resourceProfile)
}
private Optional<PendingTaskManagerSlot>
allocateResource(ResourceProfile resourceProfile) {
- final Collection<ResourceProfile> requestedSlots =
resourceActions.allocateResource(resourceProfile);
+ if (workerResourceSpec == null) {
+ // standalone mode, cannot allocate resource
Review comment:
@wangyang0918
True. That's why we annotate it as `@Nullable` and, as suggested by Tison
and updated to the PR, clearly documented that a `null` value means in
standalone mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
