[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032117#comment-15032117 ]
ASF GitHub Bot commented on FLINK-2111: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r46173139 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java --- @@ -254,13 +262,14 @@ public ExecutionGraph( ExecutionContext executionContext, JobID jobId, String jobName, + JobType jobType, Configuration jobConfig, FiniteDuration timeout, List<BlobKey> requiredJarFiles, List<URL> requiredClasspaths, ClassLoader userClassLoader) { - if (executionContext == null || jobId == null || jobName == null || jobConfig == null || userClassLoader == null) { + if (executionContext == null || jobId == null || jobName == null || jobType == null || jobConfig == null || userClassLoader == null) { throw new NullPointerException(); --- End diff -- I think it would be good to know which of the fields was actually `null`. We could use ``` executionContext = Preconditions.checkNotNull(executionContext); ... ``` > Add "stop" signal to cleanly shutdown streaming jobs > ---------------------------------------------------- > > Key: FLINK-2111 > URL: https://issues.apache.org/jira/browse/FLINK-2111 > Project: Flink > Issue Type: Improvement > Components: Distributed Runtime, JobManager, Local Runtime, > Streaming, TaskManager, Webfrontend > Reporter: Matthias J. Sax > Assignee: Matthias J. Sax > Priority: Minor > > Currently, streaming jobs can only be stopped using "cancel" command, what is > a "hard" stop with no clean shutdown. > The new introduced "stop" signal, will only affect streaming source tasks > such that the sources can stop emitting data and shutdown cleanly, resulting > in a clean shutdown of the whole streaming job. > This feature is a pre-requirment for > https://issues.apache.org/jira/browse/FLINK-1929 -- This message was sent by Atlassian JIRA (v6.3.4#6332)