kl0u commented on a change in pull request #11307: [FLINK-16371] [BulkWriter] 
Fix Hadoop Compression BulkWriter
URL: https://github.com/apache/flink/pull/11307#discussion_r389641066
 
 

 ##########
 File path: 
flink-formats/flink-compress/src/main/java/org/apache/flink/formats/compress/CompressWriterFactory.java
 ##########
 @@ -42,39 +47,57 @@
 
        private Extractor<IN> extractor;
        private CompressionCodec hadoopCodec;
+       private String hadoopCodecName;
+       private Map<String, String> hadoopConfigurationMap;
 
 Review comment:
   I think this can be `final`, as above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to