walterddr commented on a change in pull request #11189:
[FLINK-16236][yarn][hotfix] fix Yarn secure test not loading correct context
factory
URL: https://github.com/apache/flink/pull/11189#discussion_r390735933
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/security/contexts/SecurityContextFactory.java
##########
@@ -47,5 +48,5 @@ default boolean isCompatibleWith(final SecurityConfiguration
securityConfig) {
* @param securityConfig security configuration used to create context.
* @return the security context object.
*/
- SecurityContext createContext(SecurityConfiguration securityConfig);
+ SecurityContext createContext(SecurityConfiguration securityConfig)
throws SecurityContextInitializeException;
Review comment:
I altered the API to throw explicit exception instead here, to quote the
suggestion:
> we are losing the context of `e`. `e` might contain helpful information
why the context could not be instantiated
Since the API explicitly requires an override of the `isCompatibleWith`
method explicitly to check through, I think throwing an exception makes sense
here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
