twalthr commented on a change in pull request #11397: [FLINK-16217] [sql-client] catch all exceptions to avoid SQL client crashed URL: https://github.com/apache/flink/pull/11397#discussion_r392128081
########## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java ########## @@ -196,8 +196,12 @@ public void open() { if (line == null) { continue; } - final Optional<SqlCommandCall> cmdCall = parseCommand(line); - cmdCall.ifPresent(this::callCommand); + try { + final Optional<SqlCommandCall> cmdCall = parseCommand(line); + cmdCall.ifPresent(this::callCommand); + } catch (Throwable t) { Review comment: We should not catch everything and let severe errors through. The problem lies deeper in the `Executor` that should wrap all exceptions into `SqlExecutionException`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services