pnowojski commented on a change in pull request #11403:
[FLINK-16316][operators] Implement new StreamOperatorBase as a replacement for
AbstractStreamOperator
URL: https://github.com/apache/flink/pull/11403#discussion_r392201502
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorFactoryUtil.java
##########
@@ -57,7 +57,13 @@
((ProcessingTimeServiceAware)
operatorFactory).setProcessingTimeService(processingTimeService);
}
- OP op = operatorFactory.createStreamOperator(containingTask,
configuration, output);
+ // TODO: what to do with ProcessingTimeServiceAware?
+ OP op = operatorFactory.createStreamOperator(
+ new StreamOperatorInitializer<>(
+ containingTask,
+ configuration,
+ output,
+ processingTimeService));
Review comment:
@AHeise what do you think about including `processingTimeService` in
`StreamOperatorInitializer` always, regardless of the
`ProcessingTimeServiceAware`? Generally speaking what do you think about
`StreamOperatorInitializer`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
