rmetzger commented on a change in pull request #11372: [FLINK-16480] Improve error reporting on AZP URL: https://github.com/apache/flink/pull/11372#discussion_r393563257
########## File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh ########## @@ -46,7 +46,7 @@ function run_test { function test_error() { echo "[FAIL] Test script contains errors." - post_test_validation 1 "$description" "$skip_check_exceptions" + post_test_validation 1 "$description" Review comment: > do you know whether the bash tests upload the logs for failed tests? No. All directories are cleaned up after a test (in any case). > My impressions is that this will actually obfuscate errors. People pretty much only look at the last ~20 lines of the CI output, and don't properly investigate the case, resulting in several superfluous JIRAs. That is definitely a risk, I agree. But I would prefer not to rework this change for a problem we have not confirmed to exist. It is quite tedious to improve these things because of all the testing cycles in between. I would prefer to add this as is and re-adjust later if we have the feeling that people are not checking the logs carefully enough. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services