zentol commented on a change in pull request #11372: [FLINK-16480] Improve 
error reporting on AZP
URL: https://github.com/apache/flink/pull/11372#discussion_r393590049
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
 ##########
 @@ -46,7 +46,7 @@ function run_test {
 
     function test_error() {
       echo "[FAIL] Test script contains errors."
-      post_test_validation 1 "$description" "$skip_check_exceptions"
+      post_test_validation 1 "$description"
 
 Review comment:
   > But I would prefer not to rework this change for a problem we have not 
confirmed to exist.
   
   We have repeatedly seen people not properly analyzing the CI output when the 
logs are being dumped, this is not a theory.
   
   > It is quite tedious to improve these things because of all the testing 
cycles in between.
   
   That comes with the territory unfortunately. You will just have to find a 
way to reduce these cycles, e.g., only compile and test flink-core or refactor 
the scripts such that you can run things offline.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to