igalshilman commented on a change in pull request #61: [FLINK-16124] [kinesis] Support Java Kinesis Ingress / Egress URL: https://github.com/apache/flink-statefun/pull/61#discussion_r393980552
########## File path: statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kinesis/AwsAuthConfig.java ########## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.statefun.flink.io.kinesis; + +import java.net.MalformedURLException; +import java.net.URL; +import java.util.Locale; +import java.util.Objects; +import java.util.Properties; +import org.apache.flink.kinesis.shaded.com.amazonaws.regions.DefaultAwsRegionProviderChain; +import org.apache.flink.statefun.sdk.kinesis.auth.AwsCredentials; +import org.apache.flink.statefun.sdk.kinesis.auth.AwsRegion; +import org.apache.flink.streaming.connectors.kinesis.config.AWSConfigConstants; + +final class AwsAuthConfig { + private final AwsRegion awsRegion; + private final AwsCredentials awsCredentials; + + AwsAuthConfig(AwsRegion awsRegion, AwsCredentials awsCredentials) { + this.awsRegion = Objects.requireNonNull(awsRegion); + this.awsCredentials = Objects.requireNonNull(awsCredentials); + } + + Properties asFlinkConnectorProperties() { + final Properties properties = new Properties(); + setAwsRegionProperties(properties, awsRegion); + setAwsCredentialProperties(properties, awsCredentials); + + return properties; + } + + private static void setAwsRegionProperties(Properties properties, AwsRegion awsRegion) { + if (awsRegion.isDefault()) { + properties.setProperty(AWSConfigConstants.AWS_REGION, regionFromDefaultProviderChain()); + } else if (awsRegion.isId()) { + properties.setProperty(AWSConfigConstants.AWS_REGION, awsRegion.asId().id()); + } else if (awsRegion.isCustomEndpoint()) { + final AwsRegion.CustomEndpointAwsRegion customEndpoint = awsRegion.asCustomEndpoint(); + setCustomEndpointForConsumer(properties, customEndpoint); + setCustomEndpointForProducer(properties, customEndpoint); + } else { + throw new IllegalStateException("Unrecognized AWS region configuration type: " + awsRegion); + } + } + + private static void setAwsCredentialProperties( + Properties properties, AwsCredentials awsCredentials) { + if (awsCredentials.isDefault()) { + properties.setProperty( + AWSConfigConstants.AWS_CREDENTIALS_PROVIDER, + AWSConfigConstants.CredentialProvider.AUTO.name()); + } else if (awsCredentials.isBasic()) { + properties.setProperty( + AWSConfigConstants.AWS_CREDENTIALS_PROVIDER, + AWSConfigConstants.CredentialProvider.BASIC.name()); + + final AwsCredentials.BasicAwsCredentials basicCredentials = awsCredentials.asBasic(); + properties.setProperty( + AWSConfigConstants.accessKeyId(AWSConfigConstants.AWS_CREDENTIALS_PROVIDER), + basicCredentials.accessKeyId()); + properties.setProperty( + AWSConfigConstants.secretKey(AWSConfigConstants.AWS_CREDENTIALS_PROVIDER), + basicCredentials.secretAccessKey()); + } else if (awsCredentials.isProfile()) { + properties.setProperty( + AWSConfigConstants.AWS_CREDENTIALS_PROVIDER, + AWSConfigConstants.CredentialProvider.PROFILE.name()); + + final AwsCredentials.ProfileAwsCredentials profileCredentials = awsCredentials.asProfile(); + properties.setProperty( + AWSConfigConstants.profileName(AWSConfigConstants.AWS_CREDENTIALS_PROVIDER), + profileCredentials.name()); + profileCredentials + .path() + .ifPresent( + path -> + properties.setProperty( + AWSConfigConstants.profilePath(AWSConfigConstants.AWS_CREDENTIALS_PROVIDER), + path)); + } else { + throw new IllegalStateException( + "Unrecognized AWS credentials configuration type: " + awsCredentials); + } + } + + private static String regionFromDefaultProviderChain() { + return new DefaultAwsRegionProviderChain().getRegion().toLowerCase(Locale.ENGLISH); + } + + private static void setCustomEndpointForConsumer( + Properties properties, AwsRegion.CustomEndpointAwsRegion customEndpoint) { + properties.setProperty(AWSConfigConstants.AWS_ENDPOINT, customEndpoint.serviceEndpoint()); + properties.setProperty(AWSConfigConstants.AWS_REGION, customEndpoint.regionId()); + } + + private static void setCustomEndpointForProducer( + Properties properties, AwsRegion.CustomEndpointAwsRegion customEndpoint) { + URL url; + try { + url = new URL(customEndpoint.serviceEndpoint()); Review comment: You may want to switch to a URI If you are only interested in the host. URL requires a DNS lookup. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
