zhijiangW commented on a change in pull request #11408:
[FLINK-15989][FLINK-16225] Improve direct and metaspace out-of-memory error
handling
URL: https://github.com/apache/flink/pull/11408#discussion_r394112080
##########
File path:
flink-core/src/main/java/org/apache/flink/core/memory/MemorySegmentFactory.java
##########
@@ -94,7 +99,15 @@ public static MemorySegment
allocateUnpooledOffHeapMemory(int size) {
* @return A new memory segment, backed by unpooled off-heap memory.
*/
public static MemorySegment allocateUnpooledOffHeapMemory(int size,
Object owner) {
- ByteBuffer memory = ByteBuffer.allocateDirect(size);
+ ByteBuffer memory;
+ try {
+ memory = ByteBuffer.allocateDirect(size);
+ } catch (OutOfMemoryError e) {
+ if (ExceptionUtils.isDirectOutOfMemoryError(e)) {
+
LOG.error(ExceptionUtils.TM_DIRECT_OOM_ERROR_MESSAGE, e);
+ }
+ throw e;
+ }
Review comment:
For the second usage, it had a ticket
(https://issues.apache.org/jira/browse/FLINK-15981) for improving this direct
memory overhead, not sure when will be done, just FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
