[ 
https://issues.apache.org/jira/browse/FLINK-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037853#comment-15037853
 ] 

ASF GitHub Bot commented on FLINK-3073:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1433#discussion_r46558419
  
    --- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
    @@ -63,7 +57,7 @@ if [[ $STARTSTOP == "start" ]]; then
             #
             TM_MAX_OFFHEAP_SIZE="8388607T"
     
    -        if [[ "${STREAMINGMODE}" == "batch" ]] && useOffHeapMemory; then
    +        if [[ "${FLINK_TM_MEM_ALLOC}" == "eager" ]] && useOffHeapMemory; 
then
    --- End diff --
    
    For the off-heap memory case, the JVM heap memory should be reduced 
regardless of eager or lazy memory allocation. I think this can be changed to
    
    ```bash
    if useOffHeapMemory; then
    ```


> Activate streaming mode by default
> ----------------------------------
>
>                 Key: FLINK-3073
>                 URL: https://issues.apache.org/jira/browse/FLINK-3073
>             Project: Flink
>          Issue Type: Improvement
>          Components: TaskManager
>            Reporter: Robert Metzger
>            Assignee: Aljoscha Krettek
>             Fix For: 1.0.0
>
>
> Currently, TaskManagers are still started in the batch mode.
> I have the impression that more users are actually using Flink for stream 
> processing, and, the streaming mode also allows batch workloads.
> It would be nice to change that for the 1.0 release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to