danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r394773463
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchExecWindowAggregateRule.scala
##########
@@ -156,6 +162,14 @@ class BatchExecWindowAggregateRule
// TODO aggregate include projection now, so do not provide new trait will
be safe
val aggProvidedTraitSet =
input.getTraitSet.replace(FlinkConventions.BATCH_PHYSICAL)
+
+ // Because of:
+ // [CALCITE-3763] RelBuilder.aggregate should prune unused fields from the
input,
+ // if the input is a Project.
+ //
+ // the field can not be pruned if it is referenced by other expressions
+ // of the window aggregation(i.e. the TUMBLE_START/END).
+ // To solve this, we config the RelBuilder to forbidden this feature.
Review comment:
I prefer to keep it to make the change more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
