JingsongLi commented on a change in pull request #11440: 
[FLINK-16647][table-runtime-blink][hive] Miss file extension when ins…
URL: https://github.com/apache/flink/pull/11440#discussion_r394805236
 
 

 ##########
 File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemOutputFormat.java
 ##########
 @@ -194,6 +199,11 @@ public void close() throws IOException {
                        return this;
                }
 
+               public Builder<T> setExtension(String extension) {
 
 Review comment:
   `extension` is not easy to understand, can you use `OutputFileConfig` to 
support?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to