[ 
https://issues.apache.org/jira/browse/FLINK-16653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijiang closed FLINK-16653.
----------------------------
    Resolution: Fixed

Merged in master: c60d11d40dc288bc467e7414be5fe7bb2f583f17

> Introduce ResultPartitionWriterTestBase for simplifying tests 
> --------------------------------------------------------------
>
>                 Key: FLINK-16653
>                 URL: https://issues.apache.org/jira/browse/FLINK-16653
>             Project: Flink
>          Issue Type: Task
>          Components: Runtime / Network, Tests
>            Reporter: Zhijiang
>            Assignee: Zhijiang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> At the moment there are at-least four implementations of 
> `ResultPartitionWriter` interface used in unit tests. And there are about ten 
> methods to be implemented for `ResultPartitionWriter` and most of them are 
> dummy in tests.
> When we want to extend the methods for `ResultPartitionWriter`, the above 
> four dummy implementations in tests have to be adjusted as well, to waste a 
> bit efforts.
> Therefore abstract ResultPartitionWriterTestBase is proposed to implement the 
> basic dummy methods for `ResultPartitionWriter`, and the previous four 
> instances can all extend it to only implement one or two methods based on 
> specific requirements in tests. And we will probably only need to adjust the 
> ResultPartitionWriterTestBase when extending the `ResultPartitionWriter` 
> interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to